Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using itertools.pairwise #36609

Merged

Conversation

dcoudert
Copy link
Contributor

Method pairwise has been introduced in itertools version 3.10. As reported in #36493, its use breaks the condo workflow with Python 3.9. So we modify the code to avoid using pairwise.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

See discussion #36493 (comment),

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the quick follow-up!

I'll wait with setting it to positive review until the ci workflows are green, but already set it to "blocker" so that the fix applies to other PRs as well.

Copy link

Documentation preview for this PR (built with commit 388fad1; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 2, 2023
    
Method `pairwise` has been introduced in `itertools` version 3.10. As
reported in sagemath#36493,  its use breaks the condo workflow with Python 3.9.
So we modify the code to avoid using `pairwise`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
See discussion
sagemath#36493 (comment),
    
URL: sagemath#36609
Reported by: David Coudert
Reviewer(s): Tobias Diez
@vbraun vbraun merged commit a0b2ecd into sagemath:develop Nov 5, 2023
19 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants