New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean E702 etc in integer.pyx #36653

Merged

vbraun merged 10 commits into sagemath:develop from fchapoton:clean_E702_in_integer.pyx

Dec 6, 2023

Contributor

fchapoton commented Nov 5, 2023

some cleanup in the file integer.pyx

mostly fixing E702 warnings, and other cython-lint warnings

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.


          clean E702 etc in integer.pyx

a739e04

fchapoton added t: refactoring s: needs review labels

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/rings/integer.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

Contributor

mkoeppe left a comment

Otherwise LGTM

fchapoton and others added 9 commits

November 6, 2023 17:54


          Update src/sage/rings/integer.pyx

3860c75

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>


          Update src/sage/rings/integer.pyx

6c514c9

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>


          Update src/sage/rings/integer.pyx

8955ceb

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>


          Update src/sage/rings/integer.pyx

3453dea

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>


          Update src/sage/rings/integer.pyx

e48fa7f

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>


          Update src/sage/rings/integer.pyx

4d5efc6

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>


          Update src/sage/rings/integer.pyx

d3e4c70

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>


          Update src/sage/rings/integer.pyx

0d3d2fc

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>


          suggested details

b86d892

github-actions bot commented Nov 6, 2023

Documentation preview for this PR (built with commit b86d892; changes) is ready! 🎉

mkoeppe added s: positive review and removed s: needs review labels

vbraun force-pushed the develop branch from 883e05f to e349b00 Compare

November 12, 2023 16:25

vbraun merged commit 0394ea3 into sagemath:develop

12 of 19 checks passed

mkoeppe added this to the sage-10.3 milestone

github-actions bot removed the s: positive review label

fchapoton deleted the clean_E702_in_integer.pyx branch

December 6, 2023 08:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels