Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of some ParentWithGens in real and complex fields #36684

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

fchapoton
Copy link
Contributor

another step towards suppression of ParentWithGens, here in real and complex rings

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Nov 9, 2023

Documentation preview for this PR (built with commit e5333f8; changes) is ready! 🎉

@mkoeppe
Copy link
Member

mkoeppe commented Nov 9, 2023

Isn't Ring a subclass of ParentWithGens? How does it help to eliminate that class?

@fchapoton
Copy link
Contributor Author

well, we can later move the content of ParentWithGens to Ring ? in particular everything about handling the methods gen andgens ?

@mkoeppe
Copy link
Member

mkoeppe commented Nov 9, 2023

Sounds like a plan, thanks.

Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 7, 2023
…fields

    
another step towards suppression of `ParentWithGens`, here in real and
complex rings

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36684
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit b8daad8 into sagemath:develop Dec 10, 2023
20 of 24 checks passed
@fchapoton fchapoton deleted the less_parentwithgens branch December 10, 2023 14:03
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants