-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update qepcad to B 1.74 #36837
update qepcad to B 1.74 #36837
Conversation
We removed 'B' from the version number to accommodate the tarfile name from Debian
qepcad tests pass on x86_64 Linux and on macOS M1 (arm64) |
I took the liberty to promote qepcad to optional. It's in a reasonably good shape on all platforms, sort of maintained upstream, etc. |
Trivial doctest failure can be seen in the CI Linux Incremental runs, e.g. ubuntu-focal-standard https://github.com/sagemath/sage/actions/runs/7141754593/job/19449654300?pr=36837#step:11:7027
|
Yes, that seems like a good idea. |
Good idea, that also matches how the versions are commonly represented according to repology. |
Documentation preview for this PR (built with commit 95b80ca; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
As noted in sagemath#36835, we missed an update to qepcad done in 2021. It has made it into Debian and Fedora, and we use Debian's tarball and patches (most of the latter are updated versions of our B 1.72 patches) We removed 'B' from the version number to accommodate the tarfile name from Debian. We also update saclib to the latest version Fixes sagemath#36831 Fixes sagemath#36835 URL: sagemath#36837 Reported by: Dima Pasechnik Reviewer(s): Matthias Köppe
with a later develop branch, I see
which can be fixed by --- a/src/sage/interfaces/qepcad.py
+++ b/src/sage/interfaces/qepcad.py
@@ -833,7 +833,7 @@ class Qepcad:
x^2 + x*y + 3*x*z + 2*y*z + 2*z^2 - x - z < 0, \
-2*x + 1 < 0, -x*y - x*z - 2*y*z - 2*z^2 + z < 0, \
x + 3*y + 3*z - 1 < 0]
- sage: qepcad(conds, memcells=2000000) # optional - qepcad
+ sage: qepcad(conds, memcells=3000000) # optional - qepcad
2 x - 1 > 0 /\ z > 0 /\ z - y < 0 /\ 3 z + 3 y + x - 1 < 0
"""
self._cell_cache = {} |
doctest to be fixed in #36895 |
This test started to fail on Sage 10.3.beta2 after the merged update of qepcad to 1.74 in sagemath#36837 URL: sagemath#36895 Reported by: Dima Pasechnik Reviewer(s): David Coudert
As noted in #36835, we missed an update to qepcad done in 2021. It has made it into Debian and Fedora,
and we use Debian's tarball and patches (most of the latter are updated versions of our B 1.72 patches)
We removed 'B' from the version number to accommodate the tarfile name from Debian.
We also update saclib to the latest version
Fixes #36831
Fixes #36835