ntl 11.5.1

[mkoeppe]

📝 Checklist

• The title is concise, informative, and self-explanatory.
• The description explains in detail what this PR is about.
• I have linked a relevant issue or discussion.
• I have created tests covering the changes.
• I have updated the documentation accordingly.

⌛ Dependencies

• Depends on CI: Fix for failure in maximize-build-space #37252

[github-actions]

Documentation preview for this PR (built with commit fbedec1; changes) is ready! 🎉

[kwankyu]

Which CI workflow really tests the new ntl? On all platforms that I looked into, ntl is already available from the system or from the previous install.

[mkoeppe]

Which CI workflow really tests the new ntl? On all platforms that I looked into, ntl is already available from the system or from the previous install.

"CI Linux Incremental" does, in the "-minimal" configurations.
Yes, it is already installed, as it notes during the configure run:
https://github.com/sagemath/sage/actions/runs/7894674261/job/21547600785?pr=37251#step:11:526

Checking whether SageMath should install SPKG ntl...
configure: ntl has already been installed by SageMath

but then, in the summary of the configure script
https://github.com/sagemath/sage/actions/runs/7894674261/job/21547600785?pr=37251#step:11:1115 it says

ntl:                            installed SPKG version 11.4.3 will be replaced by version 11.5.1

and then (triggered by make ntl-ensure)
https://github.com/sagemath/sage/actions/runs/7894674261/job/21547600785?pr=37251#step:11:2631

[ntl-11.5.1] installing. Log file: /sage/logs/pkgs/ntl-11.5.1.log
  [ntl-11.5.1] successfully installed.

and then it proceeds to rebuild all reverse dependencies https://github.com/sagemath/sage/actions/runs/7894674261/job/21547600785?pr=37251#step:11:2780

[eclib-20231212] installing. Log file: /sage/logs/pkgs/eclib-20231212.log
[singular-4.3.2p8] installing. Log file: /sage/logs/pkgs/singular-4.3.2p8.log
[giac-1.9.0.15p0] installing. Log file: /sage/logs/pkgs/giac-1.9.0.15p0.log
[linbox-1.6.3.p1] installing. Log file: /sage/logs/pkgs/linbox-1.6.3.p1.log
  [linbox-1.6.3.p1] successfully installed.
...

and finally sagelib and the documentation
https://github.com/sagemath/sage/actions/runs/7894674261/job/21547600785?pr=37251#step:11:3082

[sagelib-10.3.beta8] installing. Log file: /sage/logs/pkgs/sagelib-10.3.beta8.log
  [sagelib-10.3.beta8] successfully installed.
make --no-print-directory sagemath_doc_html-SAGE_DOCS-no-deps
make[4]: Nothing to be done for 'all-sage'.
[sagemath_doc_html-none] installing. Log file: /sage/logs/pkgs/sagemath_doc_html-none.log
  [sagemath_doc_html-none] successfully installed.

and finally it runs the whole test suite
https://github.com/sagemath/sage/actions/runs/7894674261/job/21547600785?pr=37251#step:11:3117

Doctesting 4614 files using 3 threads.
sage -t --random-seed=229874006285459435872233631238227355545 src/doc/de/thematische_anleitungen/index.rst
    [0 tests, 0.00 s]
sage -t --random-seed=229874006285459435872233631238227355545 src/doc/de/a_tour_of_sage/index.rst
    [22 tests, 2.84 s]

[mkoeppe]

(Should we add something like this to the developer guide?)

[kwankyu]

(Should we add something like this to the developer guide?)

Perhaps no. As you explained, I was confused by the first message in the minimal build workflow. Your explanation seems too much detail to be included in the developer guide.

I tested the package on my system with "--with-system-ntl=no". We may give this tip somewhere in the developer manual, if this is not obvious to others.

For a package upgrade PR, I imagine Build & Test workflow running with ""--with-system-xxx=no". But I don't know if this is doable...

[kwankyu]

It works well. LGTM

[mkoeppe]

For a package upgrade PR, I imagine Build & Test workflow running with ""--with-system-xxx=no". But I don't know if this is doable...

I hope to merge "Build & Test" with "CI Linux Incremental" soon. (Follow-up after #36498)

[mkoeppe]

Thanks for the review!