Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update Linux platforms / runners, remove
ubuntu-trusty
,opensuse-{15.3,15.4}
#37351CI: Update Linux platforms / runners, remove
ubuntu-trusty
,opensuse-{15.3,15.4}
#37351Changes from all commits
8f25766
5ab502c
40b03f3
f9fc1f7
de1677b
54615a8
10b3238
45d3942
bce5774
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orlitzky The changes in this file reduce the platforms tested with
--enable-system-site-packages
. Is this change OK with you?(See https://github.com/sagemath/sage/actions/runs/8501570896 for the tests with 10.4.beta1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes no difference to me. Having e.g. debian-bullseye in the CI is useful only to people who want to use system packages on Debian bullseye. I don't think we have any -- not developers, anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove some old systems to keep the maintenance effort and the cpu time (relatively) constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we will continue to test what is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean supported by SageMath or the Ubuntu organization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the latter, I am not sure we should worry about "pro support". But maybe we have a policy about that that I am not aware of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saraedum I mean supported by SageMath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saraedum for reference, what is supported by SageMath and why we drop support is tracked in #32074.
Large diffs are not rendered by default.
Unchanged files with check annotations Beta
Check warning on line 799 in src/sage/interfaces/gp.py
Warning: Variable 'pi_def' referenced here was set only in doctest marked '# needs sage.libs.pari sage.symbolic'
Check warning on line 729 in src/sage/matrix/matrix1.pyx
Warning: Variable 'b' referenced here was set only in doctest marked '# needs numpy'