Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit docstrings attached to free resolutions #37542

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Mar 5, 2024

All cosmetic changes:

  • describe chain complex in the usual left-to-right direction
  • remove unnecessary warnings
  • fix the format of the tables

Changed page:
https://deploy-preview-37542--sagemath.netlify.app/html/en/reference/resolutions/sage/homology/free_resolution

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton
Copy link
Contributor

but in the same file all the resolutions are displayed with arrows <--- !

@kwankyu
Copy link
Collaborator Author

kwankyu commented Mar 6, 2024

Yes, it is customary that a chain complex is printed from right to left in terminal while in the text, it is written from left to right.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Mar 6, 2024

Look through this random sample:

https://msp.org/jsag/2018/8-1/jsag-v8-n1-p05-p.pdf

@kwankyu kwankyu force-pushed the p/edit-docstrings-free-resolution branch from 0342e62 to 2d26466 Compare March 11, 2024 07:52
Copy link

Documentation preview for this PR (built with commit 2d26466; changes) is ready! 🎉

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Mar 26, 2024

Thank you!

@vbraun vbraun merged commit 4f2428b into sagemath:develop Mar 31, 2024
16 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants