Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate is_Element, ... #38077

Merged
merged 17 commits into from
Jun 9, 2024
Merged

Deprecate is_Element, ... #38077

merged 17 commits into from
Jun 9, 2024

Commits on May 25, 2024

  1. for a in "CLASS='Element|InfinityElement|CommutativeAlgebraElement|Al… 

    …gebraElement|FieldElement|EuclideanDomainElement|PrincipalIdealDomainElement|DedekindDomainElement|IntegralDomainElement|Matrix|Vector|ModuleElement|MonoidElement|AdditiveGroupElement|MultiplicativeGroupElement|RingElement|CommutativeRingElement';SUFFIX=" ; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
    @mkoeppe
    mkoeppe committed May 25, 2024
    Configuration menu
    Copy the full SHA
    2d35995 View commit details
    Browse the repository at this point in the history

  2. Import matrix, not Matrix, from sage.matrix.constructor to avoid clashes

    @mkoeppe
    mkoeppe committed May 25, 2024
    Configuration menu
    Copy the full SHA
    3a4ed06 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. src/sage/algebras/finite_dimensional_algebras/finite_dimensional_alge… 

    …bra_element.pyx: Remove import duplicated from .pxd
    @mkoeppe
    mkoeppe committed May 26, 2024
    Configuration menu
    Copy the full SHA
    615a98a View commit details
    Browse the repository at this point in the history

  2. src/sage/calculus/functions.py: Fix up import

    @mkoeppe
    mkoeppe committed May 26, 2024
    Configuration menu
    Copy the full SHA
    331ae5f View commit details
    Browse the repository at this point in the history

  3. sage.structure.element: Deprecate is_Element, ...

    @mkoeppe
    mkoeppe committed May 26, 2024
    Configuration menu
    Copy the full SHA
    ea059fe View commit details
    Browse the repository at this point in the history

  4. fixups

    @mkoeppe
    mkoeppe committed May 26, 2024
    Configuration menu
    Copy the full SHA
    6f7f49c View commit details
    Browse the repository at this point in the history

  5. src/sage/matrix/special.py: Fixup

    @mkoeppe
    mkoeppe committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4b38dd8 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. src/sage/matrix/constructor.pyx: Define Matrix after importing from .… 

    …special
    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    43370f6 View commit details
    Browse the repository at this point in the history

  2. src/sage/homology/chain_complex.py: Fix import

    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    95e6c8b View commit details
    Browse the repository at this point in the history

  3. src/sage/algebras/finite_dimensional_algebras/finite_dimensional_alge… 

    …bra.py: Fix import, use matrix() instead of Matrix()
    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ffe8071 View commit details
    Browse the repository at this point in the history

  4. src/sage/crypto/mq/sr.py: Use matrix instead of Matrix

    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5d5977f View commit details
    Browse the repository at this point in the history

  5. src/sage/geometry/polyhedron/library.py: Use matrix instead of Matrix… 

    … (fixup)
    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    9b9f3e8 View commit details
    Browse the repository at this point in the history

  6. src/sage/groups/matrix_gps/group_element.pyx: Remove duplicate imports

    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5bedf2a View commit details
    Browse the repository at this point in the history

  7. src/sage/modular/abvar/homspace.py: Fix import

    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    83b7d06 View commit details
    Browse the repository at this point in the history

  8. src/sage/modular/cusps_nf.py: Fix import

    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    08b1220 View commit details
    Browse the repository at this point in the history

  9. src/sage/coding/binary_code.pyx: Only cimport sage.structure.element.… 

    …Matrix to hide it from 'import *'
    @mkoeppe
    mkoeppe committed May 27, 2024
    Configuration menu
    Copy the full SHA
    beb6c1d View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Merge remote-tracking branch 'upstream/develop' into is_Element_depre… 

    …cation
    @mkoeppe
    mkoeppe committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    34bf5bd View commit details
    Browse the repository at this point in the history