Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup for binary recurrence sequences #38233

Merged
merged 3 commits into from
Jul 24, 2024
Merged

cleanup for binary recurrence sequences #38233

merged 3 commits into from
Jul 24, 2024

Conversation

fchapoton
Copy link
Contributor

mostly about code cosmetics, spaces in comments

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 94ed5e3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mkoeppe
mkoeppe approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@fchapoton @mkoeppe
Apply suggestions from code review
94ed5e3 
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@vbraun vbraun merged commit 2f9da96 into sagemath:develop Jul 24, 2024
20 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@fchapoton fchapoton deleted the bin_rec_cleanup branch July 27, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: combinatorics t: refactoring v: small
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun