Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ci/write-dockerfile.sh, docker/Dockerfile: Fix Docker warning FromAsCasing #38251

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 21, 2024

Newest versions of Docker buildx give a syntax warning
https://github.com/sagemath/sage/actions/runs/9605919331/job/26494464435?pr=38227#step:13:194

WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 5)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

…Casing: 'as' and 'FROM' keywords' casing do not match
Copy link

github-actions bot commented Jun 21, 2024

Documentation preview for this PR (built with commit b61a9f4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Member

@soehms soehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM.

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
.ci/write-dockerfile.sh Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Oehms <47305845+soehms@users.noreply.github.com>
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 21, 2024

Thanks for the fixes; I should have checked the diff.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 21, 2024

Thanks!

@mkoeppe mkoeppe self-assigned this Jun 22, 2024
@vbraun vbraun merged commit 4263cef into sagemath:develop Jul 24, 2024
21 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants