Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some pep8 cleanup in four crystal files #38257

Merged
merged 2 commits into from
Jul 24, 2024
Merged

some pep8 cleanup in four crystal files #38257

merged 2 commits into from
Jul 24, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Jun 22, 2024 •
edited
Loading

a somewhat large scale pep8 cleanup in the 4 modified files in the crystals folder

also a few minor code enhancements

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

dcoudert
dcoudert suggested changes Jun 22, 2024
View reviewed changes
src/sage/combinat/crystals/alcove_path.py Outdated Show resolved Hide resolved
src/sage/combinat/crystals/generalized_young_walls.py Outdated Show resolved Hide resolved
src/sage/combinat/crystals/generalized_young_walls.py Show resolved Hide resolved
src/sage/combinat/crystals/generalized_young_walls.py Outdated Show resolved Hide resolved
src/sage/combinat/crystals/kirillov_reshetikhin.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 6effe6e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 05b29cc into sagemath:develop Jul 24, 2024
22 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@fchapoton fchapoton deleted the pep8_inside_crystals branch July 27, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
v: moderate
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe