Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/pkgs/sphinx 7.3.7, docutils 0.21.2, furo 2024.5.6 #38261

Merged
merged 3 commits into from
Jul 24, 2024
Merged

build/pkgs/sphinx 7.3.7, docutils 0.21.2, furo 2024.5.6 #38261

merged 3 commits into from
Jul 24, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 23, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 23, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 7d3a5f0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

kwankyu
kwankyu approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 24, 2024

Thanks!

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 24, 2024

Wait a minute. There's something to look at: https://github.com/sagemath/sage/actions/runs/9629901706/job/26562064031?pr=38261

@mkoeppe mkoeppe added this to the sage-10.5 milestone Jun 24, 2024
@kwankyu
Copy link
Collaborator

kwankyu commented Jun 25, 2024 •
edited
Loading

It seems that the failure is due to some change in the information saved into environment.pickle produced by Sphinx. This is just a usual hiccup in incremental doc build. Doc build from scratch is okay.

I think there is no work issue.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2024

Thanks for investigating this!

@vbraun vbraun merged commit f1477ef into sagemath:develop Jul 24, 2024
24 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: packages: standard v: minimal
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun