-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check input of composition #38366
Check input of composition #38366
Conversation
Documentation preview for this PR (built with commit c15aed8; changes) is ready! 🎉 |
@fchapoton, I think that this is an improvement, so let's get it in. In the longer run I'd really like to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Perhaps we should have a check
argument to bypass the checks, but I don't think it is necessary right now.
@fchapoton, I just realised that I cannot approve this formally, because I created the pull request... |
I think it would be good to have Travis' opinion on that. @tscrim what do you think ? |
I think it would be good to add a |
Fix #14862