Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disjoint direct product decomposition of a permutation group #38371

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

Newtech66
Copy link
Contributor

@Newtech66 Newtech66 commented Jul 15, 2024

This PR implements the disjoint direct decomposition of a permutation group, which is a partition of its domain such that the group is isomorphic to the direct product of its projection onto each part of the partition. Each part is a union of orbits.

The algorithm used is an adaptation of https://arxiv.org/abs/2004.11618v3. Additionally, the output of this algorithm is guaranteed to be the finest such partition, that is the groups formed from each part are themselves d.d.p indecomposable.

An implementation of the algorithm in the paper by the authors is available at https://github.com/peal/DisjointDirectProdDecomposition.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Jul 15, 2024

Documentation preview for this PR (built with commit 2d8e920; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mantepse mantepse mentioned this pull request Jul 16, 2024
5 tasks
@Newtech66
Copy link
Contributor Author

Why doesn't the method appear in the table of methods on the Permutation Groups page in the doc preview?

@mantepse
Copy link
Collaborator

That seems to be a problem of gen_rest_table_index with decorators. one, smallest_moved_point, orbits, ... don't appear either.

Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mantepse mantepse added s: positive review gsoc: 2024 Tag for GSoC2024 issues/PRs and removed s: needs review labels Jul 18, 2024
@vbraun vbraun merged commit 399608c into sagemath:develop Jul 24, 2024
23 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 9, 2024
    
Related to sagemath#30727.

We implement basic functionality for multivariate polynomial species,
using its representation as a pair of a permutation group and a mapping
between the domain of the permutation group and some variables. We
provide addition, multiplication, and (partitional) composition (for
some special cases). We also allow it to be constructed as a group
action (or a sequence thereof). Atomic and molecular decompositions are
automatically computed thanks to sagemath#38371.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38446
Reported by: Mainak Roy
Reviewer(s): Mainak Roy, Martin Rubey, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 13, 2024
    
Related to sagemath#30727.

We implement basic functionality for multivariate polynomial species,
using its representation as a pair of a permutation group and a mapping
between the domain of the permutation group and some variables. We
provide addition, multiplication, and (partitional) composition (for
some special cases). We also allow it to be constructed as a group
action (or a sequence thereof). Atomic and molecular decompositions are
automatically computed thanks to sagemath#38371.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38446
Reported by: Mainak Roy
Reviewer(s): Mainak Roy, Martin Rubey, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 14, 2024
    
Related to sagemath#30727.

We implement basic functionality for multivariate polynomial species,
using its representation as a pair of a permutation group and a mapping
between the domain of the permutation group and some variables. We
provide addition, multiplication, and (partitional) composition (for
some special cases). We also allow it to be constructed as a group
action (or a sequence thereof). Atomic and molecular decompositions are
automatically computed thanks to sagemath#38371.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38446
Reported by: Mainak Roy
Reviewer(s): Mainak Roy, Martin Rubey, Travis Scrimshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants