-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subs method for function field elements #38607
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 6a34481; changes) is ready! 🎉 |
I'm not really sure what the rules/conventions are around using |
@DaveWitteMorris could I get a review? (Asking since you triaged the bug report.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are my suggestions; please let me know if you have any questions.
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Thanks @tscrim! My only question is this one above:
|
Sorry, I forgot to answer that. Don’t worry about it; you do not need to add anything. It is for modularization that will be fixed by whomever knowns if something is necessary. |
Great! In that case is this ready to merge? I think the CI failures are unrelated. The tests pass on my machine at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I think this can be merged.
Fixes sagemath#38514. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies None URL: sagemath#38607 Reported by: Vincent Macri Reviewer(s): Travis Scrimshaw, Vincent Macri
Fixes #38514.
📝 Checklist
⌛ Dependencies
None