Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trying to refresh symbolic units #38655

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

trying to refresh symbolic units #38655

wants to merge 6 commits into from

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Sep 13, 2024 •
edited
Loading

by allowing the conversion constants in the stored data to be either strings or rationals

Part of the conversion table are replaced by integers or rational but not systematically.

This file is not correctly indented, but this is not fixed here.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 3dfc07c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tscrim
tscrim requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably would be better to more systematically change all of the rational conversions to rationals... Otherwise LGTM.

@fchapoton
Copy link
Contributor Author

yes, I am slightly too lazy to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @tscrim