Fix tests with singular 4.4.0p3 #38689
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Documentation preview for this PR (built with commit 69615af; changes) is ready! 🎉 |
orlitzky
reviewed
Sep 21, 2024
| @@ -176,7 +176,7 @@ | |||
| The Groebner basis modulo any product of the prime factors is also non-trivial:: | |||
| sage: I.change_ring(P.change_ring(IntegerModRing(2 * 7))).groebner_basis() | |||
| [x + 9*y + 13*z, y^2 + 3*y, y*z + 7*y + 6, 2*y + 6, z^2 + 3, 2*z + 10] | |||
| [x + ..., y^2 + 3*y, y*z + 7*y + 6, 2*y + 6, z^2 + 3, 2*z + 10] | |||
There was a problem hiding this comment.
The text above this test says that it's checking that the basis is non-trivial, so we could probably fix this one forever by simply comparing it to the trivial basis and looking for False
orlitzky
reviewed
Sep 21, 2024
| @@ -28,7 +28,7 @@ this:: | |||
| sage: with opt_ctx(red_tail=False, red_sb=False): | |||
| ....: std(I)[-1] | |||
| d^2*e^6 + 8*c^3 + ... | |||
| d^2*e^6 +...8*c^3 + ... | |||
There was a problem hiding this comment.
One of these is supposed to be tail-reduced and the other not... we could do e.g. reduced = std(I)[-1] in the first case and notreduced = std(I)[-1] in the second, with the test then being reduced != notreduced?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzz some tests to make then pass with singular>=4.4.0p3, which returns different Gröbner bases in some cases