-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add method orient
to Graph
#38778
add method orient
to Graph
#38778
Conversation
Documentation preview for this PR (built with commit bb3749d; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 172 to 175 are never reached since they are an "else" after two cases, one of which must be true. Is line 172 supposed to be an if
?
These lines can be reached setting In fact, lines 154-182 are copy-paste from method |
Ah, I see. It’s fine for now. Then can you add doctests covering those cases? |
We'll see if the new tests are sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be good. Thank you.
Thanks for the review. |
As suggested by @maxale in #38758 (comment), we add a method to apply an orientation function to a graph and obtain the corresponding directed graph.
📝 Checklist
⌛ Dependencies