src/sage: revert "touch libgap consumers" #38882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 34817df, whose only purpose was to change the mtime on several gap files, thereby triggering a rebuild on upgrade.
|
Documentation preview for this PR (built with commit f331f7f; changes) is ready! 🎉 |
fchapoton
approved these changes
Oct 29, 2024
|
Me I suppose :) We were on our third attempt to upgrade to GAP 4.13.1 with several months invested in tracking down bugs etc., and the window for the next sage release was closing... But the CI was failing because sagelib wouldn't rebuild these files after installing the new version of GAP. A better fix would have been to figure out the Makefile spaghetti, but that wastes a few hours every time you guess wrong (and I spent a few days guessing and rebuilding to no avail). This option is stupid but it got the job done quickly. |
|
ok, I understand. Thanks for cleaning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a junk commit to trigger a rebuild of certain parts of sagelib after a GAP upgrade.