-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow constructing elliptic curve from period lattice basis #38959
Open
user202729
wants to merge
14
commits into
sagemath:develop
Choose a base branch
from
user202729:elliptic-curve-from-basis
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow constructing elliptic curve from period lattice basis #38959
user202729
wants to merge
14
commits into
sagemath:develop
from
user202729:elliptic-curve-from-basis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
force-pushed
the
elliptic-curve-from-basis
branch
from
November 12, 2024 15:07
6243ff5
to
3982816
Compare
Documentation preview for this PR (built with commit 624703f; changes) is ready! 🎉 |
user202729
force-pushed
the
elliptic-curve-from-basis
branch
2 times, most recently
from
November 24, 2024 13:53
61e7d7a
to
bba7b6e
Compare
user202729
force-pushed
the
elliptic-curve-from-basis
branch
from
November 25, 2024 04:03
bba7b6e
to
5b20958
Compare
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
user202729
force-pushed
the
elliptic-curve-from-basis
branch
from
November 29, 2024 03:02
5b20958
to
624703f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title.
📝 Checklist
⌛ Dependencies
#38474 because the input is approximate, so the output must be approximate, so we must support
.period_lattice()
on approximate elliptic curve first.#39028 for modular form evaluation.