Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of meataxe extension with meson #38972

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

antonio-rojas
Copy link
Contributor

meataxe is not a library, the library is called mtx and is already searched for

meataxe is not a library, the library is called mtx and is already searched for
@antonio-rojas
Copy link
Contributor Author

tdlib and mcqd are also not found because they are header-only, so find_library doesn't work.

Copy link

github-actions bot commented Nov 15, 2024

Documentation preview for this PR (built with commit 46892d4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tobiasdiez
Copy link
Contributor

tdlib and mcqd are also not found because they are header-only, so find_library doesn't work.

They also don't seem to provide pkg-config info. So just using cc.has_header to check for the required headers, and if then set the dependency object to disabler() if not found?

@antonio-rojas
Copy link
Contributor Author

tdlib and mcqd are also not found because they are header-only, so find_library doesn't work.

They also don't seem to provide pkg-config info. So just using cc.has_header to check for the required headers, and if then set the dependency object to disabler() if not found?

Done in #38984

@antonio-rojas
Copy link
Contributor Author

Setting back to positive review, it was a simple rebase

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 6, 2024
    
meataxe is not a library, the library is called mtx and is already
searched for
    
URL: sagemath#38972
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 8, 2024
    
meataxe is not a library, the library is called mtx and is already
searched for
    
URL: sagemath#38972
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
@vbraun vbraun merged commit b31c8c0 into sagemath:develop Dec 8, 2024
17 of 22 checks passed
@antonio-rojas antonio-rojas deleted the meson-meataxe branch December 10, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants