Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support left and right actions for species #38975

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

mantepse
Copy link
Collaborator

@mantepse mantepse commented Nov 16, 2024

As in other modules, we allow the user to specify whether the group action is a left or a right action. In line with permutation groups, and also gap, the default side for an action is from the right.

Copy link

github-actions bot commented Nov 16, 2024

Documentation preview for this PR (built with commit 8033c9c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mantepse
Copy link
Collaborator Author

wow, that was quick, thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 6, 2024
    
As in other modules, we allow the user to specify whether the group
action is a left or a right action. In line with permutation groups, and
also gap, the default side for an action is from the right.
    
URL: sagemath#38975
Reported by: Martin Rubey
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 8, 2024
    
As in other modules, we allow the user to specify whether the group
action is a left or a right action. In line with permutation groups, and
also gap, the default side for an action is from the right.
    
URL: sagemath#38975
Reported by: Martin Rubey
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 3e9bc48 into sagemath:develop Dec 8, 2024
20 of 24 checks passed
@mantepse mantepse deleted the species/left_and_right_actions branch December 9, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants