-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some work on deformed Burau matrix #38987
Conversation
Documentation preview for this PR (built with commit 21ff2e8; changes) is ready! 🎉 |
Do you have some timings? |
before :
after :
So not very much faster (around 7%). But I was not expecting more. For the square of g one gets 670 ms before and 621 ms after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It's still a >10% speedup, which is good. LGTM.
some refactoring work on deformed Burau matrix to try to make it faster (this is about investigating sagemath#38869) ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38987 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
some refactoring work on deformed Burau matrix to try to make it faster (this is about investigating sagemath#38869) ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38987 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
some refactoring work on deformed Burau matrix
to try to make it faster
(this is about investigating #38869)
📝 Checklist