-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark test as random to avoid failure #39377
Mark test as random to avoid failure #39377
Conversation
Documentation preview for this PR (built with commit e75bf95; changes) is ready! 🎉 |
I think the point of the test (going back to #252) is that the number field is created successfully, so why not... sage: K
Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2 Otherwise we are only wasting a few milliseconds generating output that isn't checked and isn't very instructive. |
@orlitzky actually the following line is checked
it checks the sorted numerical values of the discriminants (if you want to be extra careful we can also check the degree, but I think this is enough) |
That part is fine. It's,
that I think is taking up a lot of space for no benefit. Sometimes you have to print a random number to show how a method works, but here, displaying a bunch of semi-random output isn't really helping to explain (or test) anything. |
(Instead of printing the subfields, I was suggesting printing |
And actually, this is a |
Cool, thanks. I have faith that CI will pass. |
Fix issue pointed out in #39153 (comment)
📝 Checklist
⌛ Dependencies