-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added check for FriCAS version #39796
base: develop
Are you sure you want to change the base?
Conversation
ffb15e1
to
c334808
Compare
Hey @dimpase |
indeed, anything earlier than 1.3.8 wasn't supported. Perhaps some tests, updated for newer FriCAS, might now fail, but that's OK |
cc-ing @mantepse just in case |
Documentation preview for this PR (built with commit c334808; changes) is ready! 🎉 |
can we use a non-deprecated API here?
|
e.g. you can use https://packaging.pypa.io/en/stable/version.html |
We can but is it causing any issue in the building process?
@dimpase the package pkg_resources definitely needs to go as it is deprecated as shown by pytorch ticket 139170 |
This pull request includes several updates to the
FriCAS
class in thesrc/sage/features/fricas.py
file. The changes introduce a minimum version requirement, add a method to retrieve the installed FriCAS version, and enhance theis_functional
method to check the version.This is an attempt to fix the issue 39784Enhancements to version handling and functionality checks:
src/sage/features/fricas.py
: Added aMINIMUM_VERSION
attribute to specify the minimum required version of FriCAS.src/sage/features/fricas.py
: Introduced aget_version
method to retrieve the installed FriCAS version.src/sage/features/fricas.py
: Updated theis_functional
method to callget_version
and check if the installed version meets the minimum requirement. If the version is not retrievable or is too old, appropriate error messages are returned.📝 Checklist
⌛ Dependencies