Skip to content

refresh the tutorial about parent/element #40169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

fchapoton
Copy link
Contributor

by explicitly declaring sub-classes of Ring as no longer recommended.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One trivial change to emphasize more that there is not really any advantage to not using Parent.

On the other hand, there is a part of me that says we should just rewrite this altogether to use Parent (rather than putting it off).

What do you think?

Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
@fchapoton
Copy link
Contributor Author

well, the removal of all methods inside rings.pyx is still slowly progressing.. but yes, it could be better to switch the tutorial to use Parent. I have no strong opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants