Skip to content

catch TypeError if magma is not available #40191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Eloitor
Copy link
Contributor

@Eloitor Eloitor commented Jun 2, 2025

When magma is not available it raises a TypeError.

sage: BruhatTitsQuotient(2, 3)
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
...

TypeError: unable to start magma because the command 'magma -n' failed: The command was not found or was not executable: magma.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jun 2, 2025

Documentation preview for this PR (built with commit 9750c2e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor

surely it should be raising RuntimeError instead? Maybe fix the downstream to raise RuntimeError? (… and current upstream codes?)

@Eloitor
Copy link
Contributor Author

Eloitor commented Jun 3, 2025

@user202729
Copy link
Contributor

Hm, that sounds like large refactor effort. Feel easiest to make a special PexpectError that (for now) inherit from TypeError, but can be changed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants