Clean up symbolic min max doctests #40736
Merged
+24
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrating the symbolic maximum of {sin,cos} over [0,1] takes a long
time on the first run. It takes 7s on my machine, but more
importantly, often takes >5s on the CI and causes "slow doctest"
warnings when it does. We mark it "long time" to avoid that.
As the name suggests, this whole file needs sage.symbolic. There are one or two lines that might run without it, but no meaningful tests can be done, so let's require it at the file level and clean up.
|
Documentation preview for this PR (built with commit 70842af; changes) is ready! 🎉 |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one
# long timeto fix some CI warnings, and move# needs sage.symbolicto the top level.