Fix fragile doctest sorting in multi_polynomial_ideal #41206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a fragile doctest failure reported in #41193.
The Issue:
The failing test in
src/sage/rings/polynomial/multi_polynomial_ideal.pyusedsorted(..., key=str)on a list of dictionaries. In Python, the string representation of a dictionary depends on the insertion order of its keys. Since the upstream librarymsolvelikely changed its internal insertion order in newer versions,key=strproduced a different sort order than expected, causing the test to fail despite the mathematical results being correct.The Fix:
I updated the test command to replace the unstable sort key with a robust one. This sorts the dictionary items before stringifying, ensuring the sorting relies on the dictionary contents rather than their internal memory layout.
Verification
I verified that this change makes the sorting immune to dictionary insertion order.
Proof of Fix: Running the following script demonstrates why
key=strfailed and why the new key succeeds:This ensures the doctest passes reliably regardless of the upstream library's behavior.
Issue
Fixes #41193 Relates to #41192
📝 Checklist
⌛ Dependencies
None.