Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Commit

Permalink
Revert "Revert "Do not overcommit so much on CPU""
Browse files Browse the repository at this point in the history
This reverts commit f459bc3.

It turns out that overcommitting makes things faster. I guess this generally
makes sense. We need to account for IO blocks, so stopping at CPUs-.2 is
probably too conservative. The load quickly drops and then we have too few
processes.
  • Loading branch information
saraedum committed Apr 30, 2018
1 parent f459bc3 commit 2e553c7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .ci/setup-make-parallelity.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ set -ex
# too high can lead to RAM being insufficient, so it's best to set the NTHREADS
# variable manually in your CI configuration.
if [ -z "$CPUTHREADS" ]; then
CPUTHREADS=$((`grep -E '^processor' /proc/cpuinfo | wc -l`+1))
CPUTHREADS=`grep -E '^processor' /proc/cpuinfo | wc -l`
fi
if [ -z "$RAMTHREADS" ]; then
RAMTHREADS=$(( `grep MemTotal /proc/meminfo | awk '{ print $2 }'` / 1024 / 1024 / 2 ))
Expand Down

0 comments on commit 2e553c7

Please sign in to comment.