Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Commit

Permalink
remove the comments about "being expensive"
Browse files Browse the repository at this point in the history
  • Loading branch information
fchapoton committed Jun 5, 2022
1 parent 8dc327a commit 999e8ef
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions src/sage/rings/polynomial/polynomial_modn_dense_ntl.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ cdef class Polynomial_dense_mod_n(Polynomial):

# Polynomial_singular_repr stuff, copied due to lack of multiple inheritance
def _singular_(self, singular=singular_default, force=False):
self.parent()._singular_(singular, force=force).set_ring() # this is expensive
self.parent()._singular_(singular, force=force).set_ring()
if self.__singular is not None:
try:
self.__singular._check_valid()
Expand All @@ -380,7 +380,7 @@ cdef class Polynomial_dense_mod_n(Polynomial):
return self._singular_init_(singular)

def _singular_init_(self, singular=singular_default, force=False):
self.parent()._singular_(singular, force=force).set_ring() # this is expensive
self.parent()._singular_(singular, force=force).set_ring()
self.__singular = singular(str(self))
return self.__singular

Expand Down
4 changes: 2 additions & 2 deletions src/sage/rings/polynomial/polynomial_rational_flint.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ cdef class Polynomial_rational_flint(Polynomial):

def _singular_(self, singular=singular_default):
"""
Return a Singular representation of self.
Return a Singular representation of ``self``.
INPUT:
Expand All @@ -347,7 +347,7 @@ cdef class Polynomial_rational_flint(Polynomial):
sage: singular(f)
3*x^2+2*x+5
"""
self._parent._singular_(singular).set_ring() # Expensive!
self._parent._singular_(singular).set_ring()
return singular(self._singular_init_())

cpdef list list(self, bint copy=True):
Expand Down
8 changes: 4 additions & 4 deletions src/sage/rings/polynomial/polynomial_singular_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@

import sage.rings.finite_rings.finite_field_constructor


def _do_singular_init_(singular, base_ring, char, _vars, order):
r"""
Implementation of :meth:`PolynomialRing_singular_repr._singular_init_`.
Expand Down Expand Up @@ -336,7 +337,7 @@ def _singular_(self, singular=singular):
if sage.rings.finite_rings.finite_field_constructor.is_FiniteField(self.base_ring()) or \
(number_field.number_field_base.is_NumberField(self.base_ring()) and self.base_ring().is_absolute()):
R.set_ring() # sorry for that, but needed for minpoly
if singular.eval('minpoly') != f"({self.__minpoly})":
if singular.eval('minpoly') != f"({self.__minpoly})":
singular.eval(f"minpoly={self.__minpoly}")
self.__minpoly = singular.eval('minpoly')[1:-1]
return R
Expand Down Expand Up @@ -490,8 +491,7 @@ def _singular_func(self, singular=singular):
sage: R(h^20) == f^20
True
"""
self.parent()._singular_(singular).set_ring() # this is expensive

self.parent()._singular_(singular).set_ring()
try:
self.__singular._check_valid()
if self.__singular.parent() is singular:
Expand All @@ -508,6 +508,6 @@ def _singular_init_func(self, singular=singular):
Use ``self._singular_()`` instead.
"""
self.parent()._singular_(singular).set_ring() # this is expensive
self.parent()._singular_(singular).set_ring()
self.__singular = singular(str(self))
return self.__singular
4 changes: 2 additions & 2 deletions src/sage/rings/polynomial/polynomial_template.pxi
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ cdef class Polynomial_template(Polynomial):

def _singular_(self, singular=singular_default):
r"""
Return Singular representation of this polynomial
Return Singular representation of this polynomial.
INPUT:
Expand All @@ -780,5 +780,5 @@ cdef class Polynomial_template(Polynomial):
sage: singular(f)
3*x^2+2*x-2
"""
self.parent()._singular_(singular).set_ring() # this is expensive
self.parent()._singular_(singular).set_ring()
return singular(self._singular_init_())

0 comments on commit 999e8ef

Please sign in to comment.