Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly disable use of grammarly across CoCalc (was: Enable use of grammarly chrome extension) #4207

Closed
dpotter opened this issue Nov 2, 2019 · 6 comments

Comments

@dpotter
Copy link

dpotter commented Nov 2, 2019

I regularly use the Grammarly Chrome browser extension to check my grammar and spelling. Would it be possible to adjust the CoCalc UI text boxes to allow it to operate?

text box requirements :

Below is a screenshot of the extension working on this text when I typed it.
Screen Shot 2019-11-01 at 8 50 31 PM

@haraldschilly
Copy link
Contributor

which parts of the CoCalc UI do you mean? e.g. Grammarly works in chat.

@haraldschilly
Copy link
Contributor

I briefly looked into this. For CodeMirror inputs, the option inputStyle: "contenteditable" might cause it to be active, but it's not really working? I also have no idea about what implications this setting has.

@williamstein
Copy link
Contributor

  1. I think he wants this for Jupyter notebooks.

  2. This issue seems to think it is impossible to use Codemirror + grammarly.

  3. We could implement spell check ourselves for codemirror. We have "underline misspelled words" already (we don't use it for markdown cells in jupyter but could), and could add something to show corrections...

@williamstein
Copy link
Contributor

Actually, what we should do is somehow change all of cocalc disable use of Grammarly. That extension mysteriously and randomly crashes things all over cocalc, but there is a way using CSS (I think) to disable it site-wise. There's a lot in these issues about how to do this: https://github.com/ianstormtaylor/slate/issues?q=is%3Aissue+grammarly+is%3Aclosed

@williamstein williamstein changed the title Enable use of grammarly chrome extension Explicitly disable use of grammarly across CoCalc (was: Enable use of grammarly chrome extension) Mar 14, 2023
@williamstein
Copy link
Contributor

  • I tried all of the data-gramm style attributes, and none of them disable Grammarly anymore.
  • I tried using this CSS, and it does seem to work to make Grammarly not appear:
grammarly-extension {
  display: none;
}
  • However, here is the thing. I wasn't able to reproduce any cases where Grammarly crashed cocalc or where making replacements didn't work, at least in our fork of slate-react. For example, even this recent issue fix: flush onDOMSelectionChange on onDOMBeforeInput ianstormtaylor/slate#4809 doesn't seem to happen for me when I try it in cocalc.

  • So I'm going to close this issue until there is a reproducible case where Grammarly actually crashes cocalc. I've heard reports that there are, but I've never seen one.

@williamstein
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants