Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flush onDOMSelectionChange on onDOMBeforeInput #4809

Merged

Conversation

BitPhinix
Copy link
Contributor

Description
Fixes the same fundamental issue as #4669 did, only triggered in a slightly different way. If the editor isn't focused the first select causes the 2nd one that Grammarly causes to be delayed by the onDOMSelectionChangeonDOMSelectionChange throttle.

Issue
Fixes: #4801

Example
Before:
before

After:
after

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2022

🦋 Changeset detected

Latest commit: 4315c3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BitPhinix
Copy link
Contributor Author

Integration tests pass locally, something seems to be up with ci. Maybe just needs a re-run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

applying Grammarly suggestions when the editor is not in focus is broken (Chrome)
2 participants