frontend/editor: catch async load errors, retry logic, and render error to refresh page #8634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or urging user to refresh the page -- #8623
haraldschilly
force-pushed
the
fix-jupyter-plain-code-8623
branch
2 times, most recently
from
9f56390 to
6c66451
Compare
…suming network problem!)
haraldschilly
force-pushed
the
fix-jupyter-plain-code-8623
branch
from
6c66451 to
5f2a58e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #8623
Not sure how well this actually fixed the ticket, but after mulling over this, I'm sure this is certainly progress. There is also a commented out code to trigger an error in
frame-tree/register.ts→withTimeoutAndRetry→ around line 120.So, with that error-triggering code, editors open files as usual, but for ipynb after about 15 seconds (3 retries) this happens:More realistic test, open cocalc, then go to the debug network settings and set it to "offline". then click on the ipynb tab. after 3 retries it looks like that: