TextDecoder pollyfill improvement and TypeScript declaration fix for DirHandle #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. of'
When using the docs TypeScript declaration file, the example async iterator
code...
const dirIter = await tjs.readdir('.');
for await (const item of dirIter) {
console.log(item.name);
}
...does not compile due to a TypeScript error.
error TS2504: Type 'DirHandle' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.
The DirHandle must be declared as an AsyncIterableIterator, which the
implementation already satisfies, instead of an AsyncIterator.
The MDN reference on `for await ... of` hints at the need for this:
Note: for await...of doesn't work with async iterators that are not async iterables.
The UTF-8-only encoder/decoder was performing poorly due to inefficient array manipulation. Applied changes from the original text-encoding package that reduce the amount of copying. Relates to saghul#316
No worries, numbers are cheap! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I missed your release with these @saghul.