add c utf8 TextDecoder/TextEncoder implementation #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI ofc won't succeeed without Quickjs patches. |
|
Hey @saghul, any time estimates on reviewing it? |
|
I hope to get some cycles next week, sorry! |
No worries, just wanted to know for some "planability" for me. |
|
So sorry for the delay, life got on the way... I finally had a chance to look at the internals patch. I'm afraid that is not something we want to expose in QuickJS. Replacing the internal string implementation with ropes is on the cards, and exposing the internals would put us in a precarious situation API-wise. Let's continue the discussion in #447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not the most efficient implementation, but ofc still much quicker than the JS implementation before.
It follows the spec pseudo code: https://encoding.spec.whatwg.org/
There is a patch needed for quickjs to expose some internal functionality. I will look further review the patch and submit it when I get a go ahead here.
expose_string_internals.zip (Github doesn't allow me to upload the patch file directly 🙄 )
Regarding to #447