Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64-apple-darwin binary release target #812

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Add aarch64-apple-darwin binary release target #812

merged 3 commits into from
Mar 28, 2023

Conversation

dbanty
Copy link
Contributor

@dbanty dbanty commented Mar 12, 2023

We could potentially put the rustup target add in tasks.setup-release-build-env. This command already exists in tasks.setup-musl so there is a bit of precident for it, but I didn't want to make that choice since it could mess up consumers who are using the CARGO_MAKE_RELEASE_FLOW_TARGET env var.

I didn't actually know the zip-release-ci-flow built in task existed, maybe I'll switch to that in Knope 😄

Tested by making this test release in my fork. The relevant new artifact runs on my M1 MacBook.

Closes #766

@sagiegurari
Copy link
Owner

@dbanty thanks for this PR!
it might take me few days to review it

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (2c07cf0) 92.67% compared to head (d154ba2) 92.75%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   92.67%   92.75%   +0.07%     
==========================================
  Files         118      118              
  Lines       23353    23317      -36     
==========================================
- Hits        21643    21628      -15     
+ Misses       1710     1689      -21     

see 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sagiegurari sagiegurari merged commit ab3cac2 into sagiegurari:master Mar 28, 2023
@sagiegurari
Copy link
Owner

@dbanty sorry it took me so long. i merged this PR
thanks a lot!!! this is really great simple change that has a lot of important impact and on next release we will have the relevant binaries available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Darwin arm64 binaries
3 participants