Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of output format autocomplete #914

Merged

Conversation

gw31415
Copy link
Contributor

@gw31415 gw31415 commented Aug 5, 2023

If we type a command like the one below, we will get output with no whitespace.
This is causing us to get a false completion when we try to autocomplete according to extra/shell/makers-completion.bash.

$ makers --loglevel error --list-all-steps --output-format autocomplete
buildbuild-flowbuild-releaseend-build-flowinit-build-flowpost-buildpre-buildworkspace-build-flowauditbench-ci-flowci-coverage-flowci-flowclippy-ci-flowexamples-ci-flowoutdatedoutdated-ci-flowoutdated-flowpost-auditpost-ci-flowpost-outdatedpost-unused-dependenciespost-verify-projectpost-workspace-ci-flowpre-auditpre-ci-flowpre-outdatedpre-unused-dependenciespre-verify-projectpre-workspace-ci-flowunused-dependenciesunused-dependencies-flowverify-projectworkspace-ci-flowworkspace-members-cizip-release-ci-flowcleandelete-lockpost-cleanpre-cleanbintray-uploadbuild-verboseconditioned-check-formatconditioned-clippytest-verbosedev-test-flow [aliases: default]formatformat-flowformat-tomlformat-toml-conditioned-flowformat-toml-flowinstall-rustfmtpost-formatpost-format-tomlpre-formatpre-format-tomlupgrade-dependencieswatch-flowclean-apidocscopy-apidocsdocsdocs-flowmarkdown-include-filespost-docspost-workspace-docspre-docspre-workspace-docsreadme-include-filesreadme-set-crate-versionworkspace-docsworkspace-docs-flowgit-addgit-commitgit-commit-messagegit-delete-merged-branchesgit-pullgit-pushgit-statuspost-git-addpost-git-commitpost-git-pushpost-git-statuspre-git-addpre-git-commitpre-git-pushpre-git-statusendinitbuild-release-for-binary-uploadbuild-publish-flowgithub-publishgithub-publish-curlgithub-publish-custom-namegithub-publish-hubgithub-publish-hublishpackagepost-packagepost-publishpre-packagepre-publishpre-publish-clean-flowpre-publish-conditioned-clean-flowpre-publish-delete-lockpublishpublish-flowupload-artifactsworkspace-publish-flowzip-release-binary-for-targetbenchbench-compilebench-conditioned-compilebench-conditioned-flowbench-flowcheckcheck-examplescheck-flowcheck-formatcheck-format-ci-flowcheck-format-flowcheck-testsclippyclippy-allow-failclippy-flowclippy-routercodecovcodecov-flowcoveragecoverage-flowcoverage-kcovcoverage-tarpaulinexamples-compileexamples-conditioned-compileinstall-clippyinstall-clippy-anyinstall-clippy-rustuppost-benchpost-checkpost-check-formatpost-clippypost-coveragepost-testpre-benchpre-checkpre-check-formatpre-clippypre-coveragepre-testtesttest-customtest-flow [aliases: dev-watch-flow]test-multi-phases-flowtest-single-threadedtest-thread-safetest-with-argsworkspace-coverageworkspace-coverage-packworkspace-members-coveragebuild-file-incrementbuild-file-increment-flowdo-on-membersemptygit-diff-files [aliases: diff-files]github-hub-findinstall-rlsinstall-rust-srcinstall-zippost-build-file-incrementpost-print-envpre-build-file-incrementpre-print-envprint-cargo-envprint-cargo-make-envprint-ci-envprint-crate-envprint-duckscript-envprint-env-flowprint-git-envprint-project-envprint-rust-envsetup-sudo-envwaitinstall-wasm-packwasm-pack-basewasm-pack-packwasm-pack-publishwasm-pack-test⏎

This PR corrects this problem by:

  • Properly Join Whitespace
  • When autocomplete is specified, do not enclose the string in [alias: ... ] when autocomplete is specified.

@sagiegurari
Copy link
Owner

@gw31415 thanks a lot! merging

@sagiegurari sagiegurari merged commit 9315f7e into sagiegurari:master Aug 10, 2023
12 checks passed
@gw31415 gw31415 deleted the fix/list_steps_for_autocomplete branch August 10, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants