move crate_target_dirs from RustInfo to CrateInfo

[xxchan]

Because it uses cargo metadata, which can be time consuming on first invoke. Otherwise RustInfo is fast to load, and CrateInfo already uses cargo metadata.

And it also sounds more reasonable.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0f4ef77) 92.88% compared to head (731149f) 92.88%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files         118      118           
  Lines       23721    23721           
=======================================
  Hits        22034    22034           
  Misses       1687     1687           

Files Changed	Coverage Δ
src/lib/environment/mod.rs	93.57% <100.00%> (ø)
src/lib/environment/mod_test.rs	95.67% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sagiegurari]

@xxchan thanks for this.
question: if i'm not wrong, both rust and crate info are invoked on startup, so what is the gain (sorry, didn't check too much)?

[xxchan]

Because

skip_rust_env_info = false
skip_crate_env_info = true

https://github.com/risingwavelabs/risingwave/blob/8ef74ad37194848ab7c75c7d39d503ad1d64025f/Makefile.toml#L81-L82

😄

[sagiegurari]

thanks @xxchan merged