default to not keeping the STAR index in shared memory #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the hard work on Finder! I look forward to applying it to the annotation of non-model species.
The primary motivation for this pull request is to make Finder play nice when running on HPC clusters by disabling STAR's shared memory genome index loading by default and adding a boolean to enable it.
The first issue is that some cluster environments (including my own) don't support STAR's shared memory loading:
alexdobin/STAR#841
BosingerLab/BALDR#11
The default for STAR's genomeLoad parameter is "NoSharedMemory".
The second issue is that the multiple invocations of
in finder and alignReads.py, as well as the genomeGenerate call do not specify an --outFileNamePrefix. This causes STAR output files (Log.out, etc.) to be written to the working directory where finder was launched, which causes crashes when running multiple jobs simultaneously from the same directory.
Instead, all output should be directed to the value of Finder's
-out_dir
parameter.I've tested this PR on the example dataset with the new boolean enabled and disabled, and the resulting predictions are the same.