This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Use Chrome Headless by default to run unit tests 😑 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 14, 2017 16:44
pirelenito
suggested changes
Jul 17, 2017
|
hm... 😕 |
pirelenito
approved these changes
Jul 19, 2017
| const isChromeAvailable = availableBrowser.indexOf('Chrome') > -1 | ||
| const isTravisChromeAvailable = (process.env['TRAVIS_STACK_FEATURES'] || '').indexOf('google-chrome') !== -1 | ||
|
|
||
| if (isChromeAvailable && (!isTravis || (isTravis && isTravisChromeAvailable))) { |
There was a problem hiding this comment.
Me and @npejo just paired on this solution, a custom detection to work-around Travis.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Sagui uses PhantomJS to run the tests. Since Chrome Headless is available in the stable release of Chrome 59, we can switch to use it by default.
This PR makes sure that we fallback to PhanthomJS if Chrome is not installed on the machine and preserves the option for consumers to override the browser by setting value for
additionalKarmaConfig.browsersinsagui.config.js