Remove the need for live MongoDB for test #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverting. mongodb-memory-server has recurring compatibility issues that causes the tests not to run without a failure response. It looks like because it depends on 3rd party binaries that may or may not be available, and once available it may take many weeks before they get added to a mongodb-memory-server release. Ref: |
|
Reverted by 12fa2a0 |
|
Restored this commit with ce6d8e4 ; we need it for CI, and will do a MongoDB version override to load a newer binary version for the memory server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remove the need for a running MongoDB when doing "npm test" by using a in-memory-instance of MongoDB when tests run (which use MongoDB). E.g. test/model.js does not need MongoDB.
Tested by running it via GitHub and GitLab CI/CD runners and at my local PC.