Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable configuration options to enable/disable different authentication providers #59

Merged
merged 3 commits into from
Feb 10, 2014

Conversation

seafoodbuffet
Copy link
Contributor

No description provided.

@sahat
Copy link
Owner

sahat commented Feb 8, 2014

@seafoodbuffet I will merge this PR tomorrow. There are few things I wanted to modify first. Instead of facebookAuth: true, githubAuth: true, etc. scattered throughout secrets.js, have an object auth = {} that contains facebook, github, google, twitter, local booleans. Or perhaps an array of strings. But object would be easier to check for presence of authentication methods.

@sahat
Copy link
Owner

sahat commented Feb 10, 2014

@seafoodbuffet I will fix it this time, but in the future could you use spaces instead of tabs in Jade templates? If you mix both, it will throw a 500 error: Invalid indentation, you can use tabs or spaces but not both.

@sahat sahat merged commit fb7b2bc into sahat:master Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants