Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py formatter: handling bad uid/gid is broken #239

Closed
hungrywolf27 opened this issue Jun 15, 2017 · 3 comments
Closed

py formatter: handling bad uid/gid is broken #239

hungrywolf27 opened this issue Jun 15, 2017 · 3 comments
Labels
Fix needed In Progress

Comments

@hungrywolf27
Copy link
Contributor

hungrywolf27 commented Jun 15, 2017 •
edited
Loading

Thanks for the 2.6.1 release! I'm working on a pull request to fix this issue, and to improve and clean up other things in the generated python script. I'm just filing the issue so it is known that the problem exists and work is being done on it. (I'm not sure if many people are using the python script at the moment.) It will be several days before the pull request is ready, though.

Issue:
Handling of bad uids/gids is currently broken in the python script because it calls os.chmod() instead of os.chown().
@sahib
Copy link
Owner

sahib commented Jun 16, 2017

Perfect, thanks.

I'm not sure if many people are using the python script at the moment.

I don't think that I ever got feedback for that one, so I'm guessing that the number of users is indeed tiny.

hungrywolf27 added a commit to hungrywolf27/rmlint that referenced this issue Jun 26, 2017
@hungrywolf27
py: Fix handling bad uid/gid (sahib#239)
7df10b6 
python script must be run as root for chown operations.
Accordingly, target uid and gid must be given by user on command line,
since they are not included in json output.
@hungrywolf27 hungrywolf27 mentioned this issue Jun 26, 2017
Merged
@sahib
Copy link
Owner

sahib commented Jul 25, 2017

Just a FYI: I merged that PR (as you probably saw) and will implement the changes I need to do on my side soon. Afterwards we should be finally able to close this ticket.

@sahib
Copy link
Owner

sahib commented Nov 21, 2017 •
edited
Loading

I implemented the things on the ToDo list here:
#240 (comment)

  • 128233c - Add basic test coverage for py2/py3
  • 17cfa75 - Fix pylint issues and nul-file terminator.
  • b5f04e7 - Fix double percentage sign.

I think, once this is in, we're got too go and can finally close this issue.

@sahib sahib closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fix needed In Progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sahib @hungrywolf27