Update or enhancing delete_repo.sh #113
Conversation
Update or enhancing delete_repo.sh
this is in the reference to the code given in index.html where we see the github_secrets.py code is entirely missing. Its entirely missing from scripts folder too
|
we don't need the github_secrets.py file. It's supposed to be created by each user at installation. |
|
@sahil-sagwekar2652 here we are just enhancing the delete_repo.sh, if it feels not good to you- then you can just close this PR then. Its fine |
|
Don't get me wrong, the idea is good. We just need better implementation. Let me know if you want to work on it or else I'll close it. |
|
so what all things i need to correct in this |
|
First check the flake8 linter output (github actions) and fix the styling accordingly. You need to import the key from the github_secrets.py file instead of passing it as a comman line argument. |
sahil-sagwekar2652
added
gssoc23
|
can you assign this to someone else, as i'm unable to do it |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| """Get the GitHub personal access token and username and print them to the console.""" | ||
|
|
||
| github_api_token, username = get_github_secrets() | ||
| print("GitHub personal access token:", github_api_token) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
|
|
||
| github_api_token, username = get_github_secrets() | ||
| print("GitHub personal access token:", github_api_token) | ||
| print("GitHub username:", username) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Have already mentioned the issue
closes #111