Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ffmpeg to copy the stream if the requested dimensions are similar enough #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KodeCR
Copy link

@KodeCR KodeCR commented Nov 27, 2018

These changes allow homebridge-dafang to copy the stream instead of re-encoding it when the requested dimensions are similar to the stream coming from the camera. It detects the width and height from the stream automatically using ffprobe. I also refactored the ffmpeg option handling to support it more easily, now allowing global_options and input_options. Note that this doesn't take into account bitrate and fps. Also note the (image) source no longer is expected to contain the "-i ".

@sahilchaddha
Copy link
Owner

@KodeCR PR looks good.
Allow me some time to test it and upload the new version to npm.

@mkormendy
Copy link
Contributor

mkormendy commented Jan 21, 2019

@sahilchaddha for uploading to npm, just use release-it. (npm install -g release-it).
You can also include it in your CI process.

@netRunner0 netRunner0 mentioned this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants