Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sifo580 Adding Podman to be used for registry access #15

Merged
merged 14 commits into from
Mar 4, 2021
Merged

Feature/sifo580 Adding Podman to be used for registry access #15

merged 14 commits into from
Mar 4, 2021

Conversation

spfrancis
Copy link
Member

@spfrancis spfrancis commented Mar 1, 2021 •
edited
Loading

what

Updating anvil image to install podman utility.

  • This will allow a daemonless way to perform docker commands in a container.

why

  • The first usecase will be to perform a login and push/pull.
  • There will be other usecases for needing podman.

@spfrancis spfrancis requested a review from a team as a code owner March 1, 2021 19:08
@bstascavage
Copy link
Member

  1. Can you update the description with a little info about the change?
  2. There is a static code analysis failure that needs to be fixed.

saic-statonb
saic-statonb reviewed Mar 1, 2021
View reviewed changes
src/docker/Dockerfile Outdated Show resolved Hide resolved
RothAndrew
RothAndrew suggested changes Mar 1, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/docker/Dockerfile Outdated Show resolved Hide resolved
src/docker/Dockerfile Outdated Show resolved Hide resolved
src/docker/Dockerfile Outdated Show resolved Hide resolved
src/docker/Dockerfile Outdated Show resolved Hide resolved
src/docker/Dockerfile Outdated Show resolved Hide resolved
@RothAndrew
Copy link
Contributor

Missing automated test

saic-statonb
saic-statonb requested changes Mar 1, 2021
View reviewed changes
src/docker/Dockerfile Outdated Show resolved Hide resolved
src/docker/Dockerfile Outdated Show resolved Hide resolved
src/docker/Dockerfile Outdated Show resolved Hide resolved
@spfrancis spfrancis changed the title Feature/sifo580 podman Feature/sifo580 Adding Podman to be used for registry access Mar 1, 2021
@saic-statonb
Copy link
Member

/test

saic-statonb
saic-statonb previously approved these changes Mar 4, 2021
View reviewed changes
RothAndrew
RothAndrew suggested changes Mar 4, 2021
View reviewed changes
src/docker/Dockerfile Outdated Show resolved Hide resolved
@RothAndrew
Copy link
Contributor

One small nitpick, then LGTM

spfrancis
spfrancis commented Mar 4, 2021
View reviewed changes
Copy link
Member Author

@spfrancis spfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@saic-statonb
Copy link
Member

/test

spfrancis
spfrancis commented Mar 4, 2021
View reviewed changes
Copy link
Member Author

@spfrancis spfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@saic-statonb saic-statonb merged commit 9973e66 into main Mar 4, 2021
@saic-statonb saic-statonb deleted the feature/sifo580Podman branch March 4, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saic-statonb saic-statonb saic-statonb approved these changes

@RothAndrew RothAndrew RothAndrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spfrancis @bstascavage @RothAndrew @saic-statonb