Added serverless #26
Merged
Added serverless #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
bstascavage
previously approved these changes
Aug 11, 2021
|
@shawju make sure you have your settings correct: #23 (comment) |
|
/test |
…and added serverless
…and added serverless
|
/test |
|
/test |
1 similar comment
|
/test |
|
/test |
|
/test |
|
/test |
|
/test |
|
/test |
|
/test |
|
/test |
1 similar comment
|
/test |
|
/test |
2 similar comments
|
/test |
|
/test |
|
/test |
|
/test |
|
/test |
RothAndrew
suggested changes
Aug 16, 2021
|
I'm reviewing from a compliance perspective only. Should get another approval from anvil team before merging |
bstascavage
requested changes
Aug 16, 2021
src/docker/Dockerfile
Outdated
| @@ -85,7 +86,7 @@ RUN wget -O /root/task.tar.gz "https://github.com/go-task/task/releases/download | |||
| # Install shellcheck. Get versions from https://github.com/koalaman/shellcheck/releases | |||
| ARG SHELLCHECK_VERSION="0.7.1" | |||
| ENV SHELLCHECK_VERSION=${SHELLCHECK_VERSION} | |||
| # hadolint ignore=DL3003 | |||
| # hadolint ignore=DL3003,DL3047 | |||
There was a problem hiding this comment.
I don't think we want this ignore here. We should update wget to use the --progress flag.
See here
src/docker/Dockerfile
Outdated
| @@ -183,20 +195,23 @@ RUN asdf plugin add python \ | |||
| # NOTE: PIPENV_VERSION is an env var that is used by pipenv, so it can't be used here. ref: https://github.com/pypa/pipenv/issues/3633#issuecomment-478250721 | |||
| ARG PIP_ENV_VERSION="2020.11.15" | |||
| ENV PIP_ENV_VERSION=${PIP_ENV_VERSION} | |||
| # hadolint ignore=DL3042 | |||
There was a problem hiding this comment.
I don't think we want this ignore here.
See here
| RUN dnf -y install skopeo-${SKOPEO_VERSION} \ | ||
| && dnf clean all \ | ||
| && rm -rf /var/cache/yum/ \ | ||
| && rm -rf /var/tmp/* /tmp/* /var/tmp/.???* /tmp/.???* | ||
|
|
||
| # hadolint ignore=DL3059 |
|
/test |
bstascavage
requested changes
Aug 16, 2021
spec/skopeo_spec.sh
Outdated
| The output should include "${SKOPEO_VERSION}" | ||
| The status should eq 0 | ||
| End | ||
| It "validates tool is installed by checking version" |
There was a problem hiding this comment.
One last thing
This file needs to be indented like the other shellspec files
|
/test |
|
/test |
RothAndrew
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references