Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Updates #40

Merged
merged 3 commits into from
Oct 21, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 12.18.3
nodejs 18.11.0
4 changes: 2 additions & 2 deletions spec/gocritic_spec.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

Describe "printVersion()"
printVersion() {
cd $(find / -name "go-critic@*" -type d | head -n1); cd checkers; gocritic version
echo $(find / -name "go-critic@*" -type d 2>/dev/null)
}

It "validates tool is installed by checking version"
When call printVersion
The stderr should be present
The output should include "${GOCRITIC_VERSION}"
The status should eq 0
End
End
2 changes: 1 addition & 1 deletion spec/kubectl_spec.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Describe "printVersion()"
printVersion() {
kubectl version --client=true | grep "${KUBECTL_VERSION}"
kubectl version --client=true --output=yaml | grep "${KUBECTL_VERSION}"
}

It "validates tool is installed by checking version"
Expand Down
13 changes: 0 additions & 13 deletions spec/shellspec_spec.sh

This file was deleted.

13 changes: 7 additions & 6 deletions spec/spec_helper.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
#!/usr/bin/env shellspec

#shellcheck shell=sh
set -eu

# set -eu

# shellspec_spec_helper_configure() {
# shellspec_import 'support/custom_matcher'
# }
spec_helper_precheck() {
minimum_version "0.28.1"
if [ "$SHELL_TYPE" != "bash" ]; then
abort "Only bash is supported."
fi
}
93 changes: 48 additions & 45 deletions src/docker/Dockerfile

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions updates/aws_cli_spec.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

Describe "Check for a AWS CLI update"
Include ./lib_updates
It "validates AWS CLI is up-to-date via pip"
When call getLatestVersionFromPip awscli
It "validates AWS CLI is up-to-date via asdf"
When call getLatestVersionFromAsdf awscli
The output should include "${AWS_CLI_VERSION}"
The status should eq 0
End
Expand Down
2 changes: 1 addition & 1 deletion updates/pipenv_spec.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Describe "Check for a Pipenv update"
Include ./lib_updates
It "validates Pipenv is up-to-date via pip"
When call getLatestVersionFromPip pipenv
The output should include "${PIPENV_VERSION}"
The output should include "${PIP_ENV_VERSION}"
The status should eq 0
End
End