Revise token injection and add multiple Gitlab providers support #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piggz
reviewed
Dec 28, 2021
| PackageName: Chum GUI | ||
| Type: desktop-application | ||
| Categories: | ||
| - System |
There was a problem hiding this comment.
This category is missing from new categories function ;)
There was a problem hiding this comment.
Ha, it is not. See https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/qml/pages/CategoriesPage.qml#L104 - map is created by linking via IDs separated by ;. As soon as package has one of the listed IDs, it will be included into that category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokens are now expected to be in
rpmsubfolder or in the main folder for OBS.GitLab tokens are given in a format
If a single site is given,
"are not needed.In addition, Chum section was added to RPM SPEC and README title was adjusted.
Fixes #39